Maintenance 3 #5557
Open
Maintenance 3 #5557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
maintenance3
branch
3 times, most recently
from
ae25a1d to
ed4d917
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5557 +/- ##
==========================================
- Coverage 83.23% 83.22% -0.02%
==========================================
Files 277 277
Lines 29265 29282 +17
==========================================
+ Hits 24359 24370 +11
- Misses 4906 4912 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
maintenance3
branch
3 times, most recently
from
ba3cd70 to
694289e
Compare
ShadowCurse
added
Status: Awaiting review
JackThomson2
reviewed
Dec 4, 2025
ShadowCurse
force-pushed
the
maintenance3
branch
2 times, most recently
from
a0966ff to
6587ebb
Compare
JackThomson2
reviewed
Dec 8, 2025
ShadowCurse
force-pushed
the
maintenance3
branch
3 times, most recently
from
c15a161 to
e2e15fe
Compare
Manciukic
reviewed
Dec 9, 2025
| /// Represent it as u8 to give it a known size. | ||
| /// All used types fit in u8. | ||
| #[allow(clippy::cast_possible_truncation)] | ||
| #[repr(u8)] |
Contributor
There was a problem hiding this comment.
QEMU uses u16 and there's actually already almost 40 of them!
https://elixir.bootlin.com/qemu/v7.2.10/source/include/hw/virtio/virtio.h#L113
Contributor
Author
There was a problem hiding this comment.
I just selected the smallest type because it can hold 256 values which is over the top for what we need. This is also correlated to the fact that sometimes we need to convert this type to u16 or u32, so u8 (o u16) will work.
Contributor
There was a problem hiding this comment.
can we do u16 for consistency then?
Contributor
Author
There was a problem hiding this comment.
I would prefer to keep it u8 as this is the most flexible type in case we will do some other change that would benefit from having virtio type as u8.
ShadowCurse
force-pushed
the
maintenance3
branch
from
e2e15fe to
d36ab1f
Compare
ShadowCurse
requested review from
kalyazin,
pb8o and
xmarcalx
as code owners
Replace fmt.toml with new rustfmt.toml Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Fix new clippy warnings Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Instead of using `u32` values directly from generated `virtio_ids` create an enum backed by u8 with all types we actually use Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add a trait method to VirtioDevice to get a unique device id. This can be used in default imps of some other methods to print current device id in case of an error/warning etc. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Replace different `kick` implementations with a default implementation in the `VirtioDevice` trait. Change the `kick` logic to just re-trigger queue events instead of manually calling different internal queue processing functions. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Update names for remaining BK pipelines. This is needed because BK labels are used as a part of the s3 path where the BK artifacts are uploaded. Removing emojis and normalizing names simplifies these paths. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
These variables are no longer needed for A/B since A/B scripts use `metrics.json` files which are always emitted, instead of `test-report.json`. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Fix incorrect instructions about running `tools/ab_test.py` with manually collected test results. Move A/B visualization section after manual test collection section as `tools/ab_plot.py` script is using same inputs as `tools/ab_test.py` Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
There is no need for build directory or ci artifacts to be present to run style checks. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
maintenance3
branch
from
d36ab1f to
9d651da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
u32virtio device type with actualVirtioDeviceTypeenumidmethod toVirtioDevicetraitkickmethod inVirtioDevicetrait that re-triggers queue eventfds instead ofdoing manual queue reprocessing
Reason
Maintenance
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.