-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Clarify supported CPU models for CPU templates #5142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bba8690
to
5144394
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5142 +/- ##
==========================================
- Coverage 83.02% 83.02% -0.01%
==========================================
Files 250 250
Lines 26911 26902 -9
==========================================
- Hits 22344 22335 -9
Misses 4567 4567
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/data/msr/msr_list_C3_INTEL_CASCADELAKE_5.10host_5.10guest.csv
Outdated
Show resolved
Hide resolved
7bf9340
to
c31f7b2
Compare
4cb2c03
to
9d2ff4a
Compare
Do CPU model check for static CPU templates in accordance with the doc change in the prev commit. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
We made it more specific which CPU models are supported by CPU templates. Now we can remove unnecessary files for an integration test that captures rdmsr values when CPU templates are applied. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
At that time of creating the directory, there are only custom CPU templates corresponding to static CPU templates. But now there is a CPU template that doesn't have a corresponding static CPU template (i.e. aarch64_with_sve_and_pac.json), there is no longer sense to name the dir "static_cpu_templates". Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
9d2ff4a
to
c8848a4
Compare
@roypat sorry. I needed to fix an integration test failure that sets C3 template unconditionally on Intel Sapphire Rapids. |
Changes
Reason
The existing CPU templates won't support Intel Sapphire Rapids. Before adding it, let's make the documentation description clearer around what CPU models are supported for each CPU template.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.[ ] If a specific issue led to this PR, this PR closes the issue.Runbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO
.rust-vmm
.