Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add per net device metrics #4145

Merged
merged 13 commits into from
Oct 18, 2023
Merged

feat: Add per net device metrics #4145

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4aabb7a
feat(metrics)(net): refactor and add per net device metrics
Oct 11, 2023
b370ce3
feat(metrics)(net): per device net metrics for report_net_event_fail
Oct 11, 2023
1e45431
feat(metrics)(net): Add per device net metrics in CHANGELOG
Oct 11, 2023
13839e5
feat(metrics)(net): Add unit test for net metrics
Oct 11, 2023
24ecef2
feat(metrics)(net): Use a lock to access net metrics
Oct 12, 2023
cce04ed
feat(metrics)(net): Use iface_id to emit per net device metrics
Oct 13, 2023
6a0fb22
chore(metrics)(net): better CHANGELOG & lowercase for net_metrics macro
Oct 16, 2023
ddc4430
chore(metrics)(net): better name for NetMetricsSerializer
Oct 16, 2023
9b48636
chore(metrics)(net): remove new() for NetDeviceMetrics and proxy
Oct 16, 2023
6d47036
chore(metrics)(net): implement review feedback for flush_metrics
Oct 16, 2023
c3e365b
feat(metrics)(net): add ci test to validate net metrics
Oct 16, 2023
8d4b2f3
feat(metrics)(net): Use Arc to allow storing metris in Net
Oct 17, 2023
42d52c0
Merge branch 'main' into perdev_net_metrics
roypat Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
capability checks that Firecracker performs during boot. If any of
these fields are in use, minimal target snapshot version is
restricted to 1.5.
- [#4145](https://github.com/firecracker-microvm/firecracker/pull/4145):
Added support for per net device metrics. Now, along with aggregated
wearyzen marked this conversation as resolved.
Show resolved Hide resolved
network device metrics, metrics per network device with also be emitted.
wearyzen marked this conversation as resolved.
Show resolved Hide resolved

### Changed

Expand Down