Skip to content

Conversation

raduiliescu
Copy link
Contributor

Reason for This PR

Fixes #2785

Description of Changes

Clearly mention that secure isolation and defense in depth can be
guaranteed only if prod-host-setup recommendations are implemented.

Remove the mention that Firecracker won't start without
the jailer in the future.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The issue which led to this PR has a clear conclusion.
  • This PR follows the solution outlined in the related issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.

Copy link
Contributor

@georgepisaltu georgepisaltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please fix the style tests as well.

@raduiliescu raduiliescu force-pushed the jailer branch 2 times, most recently from 8684a39 to d095315 Compare December 10, 2021 16:41
alindima
alindima previously approved these changes Dec 14, 2021
Remove the mention that Firecracker won't start without
the jailer in the future.

Clearly mention that secure isolation and defense in depth can be
guaranted only if prod-host-setup recommendations are implemented.

Signed-off-by: Radu Iliescu <riliescu@amazon.com>
@georgepisaltu georgepisaltu merged commit 23c0d2e into firecracker-microvm:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Please remove the implied "roadmap" to remove the ability ro run Firecracker without jailer

4 participants