Test instrumented binary

[JonathanWoollett-Light]

Add a test that checks a simple integration tests works when Firecracker is instrumented with src/clippy-tracing and trace level logs are enabled.

[MuhtasimTanmoy]

Is it active?

[JonathanWoollett-Light]

Is it active?

@MuhtasimTanmoy, Yes, any contribution on this issue would be great.

[LDagnachew]

Hi, we're a group of students at UT Austin looking to contribute to virtualization-related open-source projects for our class. We came across this issue and would like to work on it @JonathanWoollett-Light, if you could assign this to us please.

Thanks so much!

[JonathanWoollett-Light]

@LDagnachew Hi, I'm no longer a maintainer on this project, and I expect the view on some of these issues may have changed. I think @xmarcalx or @bchalios can provide some more insight.

[LDagnachew]

Got it, thanks so much!

[xmarcalx]

Hi @LDagnachew, sorry for the late reply, of course you can pick up this ticket.
Usually when issues have no assignee means that are up for grabs and we always welcome contributions!

When you start to work on it just assign yourself and post update/questions in the comment section or PR such that we will be able to pick them up in our process and respond to you.

We look forward to see your solution to this problem!

[LDagnachew]

Hi @xmarcalx sorry for another late reply, but just wanted to update that we are currently working on it! Also, not sure if i can assign myself to the ticket currently, but regardless I'll submit a PR when I'm done.

[LDagnachew]

Just a quick question @xmarcalx , as I'm starting to be confused with what the issue is that I should be testing for in the first place. There exists a file, /tests/integration_tests/functional/test_log_instrument.py that to my understanding already checks logs for simple integration tests running with tracing enabled. Not sure if I'm understanding the issue correctly or not.

[kalyazin]

Hi @LDagnachew . The test in the tests/integration_tests/functional/test_log_instrument.py verifies that the log-instrument crate is able to instrument a program. Specifically it uses a number of example programs (src/log-instrument/examples/one.rs to src/log-instrument/examples/five.rs). What we a looking in this issue is a test that would verify that log-instrument is able to instrument Firecracker in particular. The test can run an instrumented Firecracker binary and look for meaningful calls to appear in the trace (eg processing a block request or a network packet).