Add support for the MMDS configuration. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The handler looks good. How about adding the IP address to Config struct? |
|
Thank you for your comment. |
yjuba
force-pushed
the
add-mmds-config
branch
from
46b507d to
2abe320
Compare
|
Sorry for the late reply. Looks good to me. Can you rebase the branch against master? You don't have to change go.mod and go.sum if they conflict. This PR doesn't add any new dependencies. |
Signed-off-by: Yutaka Juba <yutaka.j+github@gmail.com>
…he handler. Signed-off-by: Yutaka Juba <yutaka.j+github@gmail.com>
Signed-off-by: Yutaka Juba <yutaka.j+github@gmail.com>
yjuba
force-pushed
the
add-mmds-config
branch
from
2abe320 to
d09193c
Compare
|
Thank you for your comment. I haven't made any changes to the code, but the test timed out. |
|
That's odd. Let me restart the BuildKite test. |
|
The error we have right now is |
Merged
kzys
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support the configuration of MMDS in the SDK.
Issue #, if available:
Description of changes:
mmds/configin handlers.go.mmds/configin firecracker.go.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.