Don't allow fs provider to reach above root dir. #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .use(superstatic(opts)); | ||
|
|
||
| request(app) | ||
| .get('/dir/') |
There was a problem hiding this comment.
Probably missing something, but how does this test a file with spaces? Isn't it just getting the index.html?
|
A few nits, back to you |
|
Drastically simplified implementation. I don't think there's any reason to allow parent directory pathing at all. |
|
LGTM, thanks |
cbraynor
pushed a commit
that referenced
this pull request
Feb 17, 2016
Don't allow fs provider to reach above root dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that the fs provider cannot serve files above the specified root. Previously, a string of
../../../would let you access files outside the specified public directory.