Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken array-in snippets #360

Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix broken array-in snippets #360

merged 3 commits into from
Nov 9, 2023

Conversation

morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Nov 8, 2023 •
edited
Loading

@morganchen12
Copy link
Contributor Author

Overriding CLA failure since I have a signed CLA.

MarkDuckworth
MarkDuckworth reviewed Nov 8, 2023
View reviewed changes
Copy link

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to 'in' snippets look good. The array-contains-any snippets should not be modified.

firestore-next/test.firestore.js Outdated Show resolved Hide resolved
firestore/test.firestore.js Outdated Show resolved Hide resolved
snippets/firestore-next/test-firestore/array_contains_any_filter.js Outdated Show resolved Hide resolved
@morganchen12 morganchen12 merged commit 1f9e797 into master Nov 9, 2023
3 checks passed
@morganchen12 morganchen12 deleted the mc/array branch November 9, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth Awaiting requested review from MarkDuckworth

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query from documentation doesn't return expected result
2 participants
@morganchen12 @MarkDuckworth