-
Notifications
You must be signed in to change notification settings - Fork 1.5k
infra: Remove ObjC quickstarts #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge main
refactor(storage): Move storage qs to root of storage directory
fix(infra): Update scripts/test.sh to dynamically get scheme
This reverts commit 7f27d68.
chore: Rename more performance fixes
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a comprehensive cleanup and modernization of the Firebase iOS quickstarts. It removes all Objective-C examples, streamlining the project structure and reducing maintenance overhead. Concurrently, it updates project configurations to embrace modern Swift language features and dependency management through Swift Package Manager, ensuring the remaining Swift examples are up-to-date and leverage the latest platform capabilities. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a significant and well-executed infrastructure update. It successfully removes legacy Objective-C quickstart examples across multiple projects, streamlining the repository. Additionally, it modernizes the remaining Swift projects by migrating them from CocoaPods to Swift Package Manager, which is a great improvement for dependency management. The changes also include valuable updates like adopting modern Swift syntax (e.g., @main), improving concurrency safety with @MainActor annotations, and replacing a third-party reachability library with Apple's native Network framework. The project files and schemes have been cleaned up consistently. Overall, these changes greatly improve the codebase's quality, maintainability, and modernity. I have not found any issues with the implementation.
ncooke3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review
Corresponding Firebase PR: firebase/firebase-ios-sdk#15478
This PR migrate the quickstart examples from CocoaPods to Swift Package Manager (SPM). This involves several related changes:
names (e.g., InAppMessagingExampleSwift to InAppMessagingExample).