Skip to content

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 12, 2025

Corresponding Firebase PR: firebase/firebase-ios-sdk#15478

This PR migrate the quickstart examples from CocoaPods to Swift Package Manager (SPM). This involves several related changes:

  • SPM Migration: Most of the quickstart projects have been updated to use SPM for managing Firebase dependencies, moving away from CocoaPods.
  • Project and Scheme Renaming: Many Xcode projects, schemes, and targets have been renamed to be more consistent and simplify testing infrastructure. For example, suffixes like "Swift" have been removed from target
    names (e.g., InAppMessagingExampleSwift to InAppMessagingExample).
  • CI Updates: The GitHub Actions workflows have been significantly updated to build and test the quickstarts using SPM.
  • Legacy Code Removal: The Objective-C quickstart examples have been removed to focus on the Swift versions.
  • Bug Fixes and Refinements: Various smaller fixes and improvements have been made, such as fixing test target configurations, addressing warnings, and removing unused dependencies like Reachability.

chore: Rename more performance fixes
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a comprehensive cleanup and modernization of the Firebase iOS quickstarts. It removes all Objective-C examples, streamlining the project structure and reducing maintenance overhead. Concurrently, it updates project configurations to embrace modern Swift language features and dependency management through Swift Package Manager, ensuring the remaining Swift examples are up-to-date and leverage the latest platform capabilities.

Highlights

  • Legacy Quickstart Removal: The pull request systematically removes all Objective-C quickstart examples across various Firebase features, including A/B Testing, Analytics, Authentication, Remote Config, Crashlytics, and Database. This significantly streamlines the codebase by eliminating outdated examples.
  • Project Configuration Modernization: Project files (.xcodeproj/project.pbxproj, .xcodeproj/xcshareddata/xcschemes/*.xcscheme) have been updated to reflect the removal of legacy code, incorporate Swift Package Manager for dependencies, and align with modern Xcode and Swift language features, such as updating the Swift version to 6.0 and using @main for app entry points.
  • Network Status Implementation Update: The Crashlytics quickstart's network status monitoring has been modernized to utilize Apple's native Network framework (NWPathMonitor) instead of the third-party Reachability.swift library, improving consistency and leveraging platform-native capabilities.
  • Codebase Refinement: Minor code adjustments were made in existing Swift files, such as updating default string values in AppConfig.swift and applying @MainActor attributes to protocols and extensions in the Authentication quickstart, enhancing concurrency safety and adhering to modern Swift best practices.
Ignored Files
  • Ignored by pattern: .github/workflows/** (15)
    • .github/workflows/abtesting.yml
    • .github/workflows/analytics.yml
    • .github/workflows/authentication.yml
    • .github/workflows/check.yml
    • .github/workflows/config.yml
    • .github/workflows/crashlytics.yml
    • .github/workflows/database.yml
    • .github/workflows/firebaseai.yml
    • .github/workflows/firestore.yml
    • .github/workflows/functions.yml
    • .github/workflows/inappmessaging.yml
    • .github/workflows/installations.yml
    • .github/workflows/messaging.yml
    • .github/workflows/performance.yml
    • .github/workflows/storage.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant and well-executed infrastructure update. It successfully removes legacy Objective-C quickstart examples across multiple projects, streamlining the repository. Additionally, it modernizes the remaining Swift projects by migrating them from CocoaPods to Swift Package Manager, which is a great improvement for dependency management. The changes also include valuable updates like adopting modern Swift syntax (e.g., @main), improving concurrency safety with @MainActor annotations, and replacing a third-party reachability library with Apple's native Network framework. The project files and schemes have been cleaned up consistently. Overall, these changes greatly improve the codebase's quality, maintainability, and modernity. I have not found any issues with the implementation.

Copy link
Member Author

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@ncooke3 ncooke3 requested a review from paulb777 November 14, 2025 18:56
@ncooke3 ncooke3 merged commit c39fe8d into main Nov 14, 2025
37 of 38 checks passed
@ncooke3 ncooke3 deleted the nc/quickstarts branch November 14, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants