-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Firebase AI] Update bundle ID and remove FirebaseVertexAI dep #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the bundle ID of the Firebase AI example project to com.google.firebase.quickstart.FirebaseAIExample
to align with the naming convention used in other quickstart examples. Additionally, it removes the dependency on the FirebaseVertexAI
framework from the project.
Highlights
- Bundle ID Update: The bundle identifier for the Firebase AI example has been changed from
com.google.firebase.VertexAISample
tocom.google.firebase.quickstart.FirebaseAIExample
. - Dependency Removal: The pull request removes the
FirebaseVertexAI
framework dependency from the project.
Changelog
- firebaseai/FirebaseAIExample.xcodeproj/project.pbxproj
- Updated the
PRODUCT_BUNDLE_IDENTIFIER
tocom.google.firebase.quickstart.FirebaseAIExample
in the project settings (lines 546 and 576 before, lines 544 and 574 after). - Removed the
FirebaseVertexAI
framework dependency from the project (lines 318, 319, 647, 648, 665, 666 before, removed after).
- Updated the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A bundle ID's changed,
Dependencies rearranged,
For clarity's sake,
A new path we take,
Firebase's quickstart, now trained.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the dependency on the FirebaseVertexAI
framework and updates the bundle ID. The changes are straightforward and well-documented. No style guide was provided, so I've defaulted to common best practices for Xcode project files.
Merge Readiness
The changes in this pull request are clean and well-explained. I have no major concerns. However, please ensure that all other reviewers approve this code before merging. I am unable to approve pull requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated the bundle ID to
com.google.firebase.quickstart.FirebaseAIExample
to follow the pattern of the other quickstarts and removed the dependency on theFirebaseVertexAI
framework.