Compose workspace config #1450
Merged
Compose workspace config #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added compose as an option to use Firebase
Added Firebase Config functionality
thatfiredev
reviewed
Jan 24, 2023
There was a problem hiding this comment.
@millandavid Thanks for your PR!
I've added some initial comments that I think we should address before going into the ViewModel step.
config/app/src/main/java/com/google/samples/quickstart/config/kotlin/MainComposeActivity.kt
Outdated
Show resolved
Hide resolved
config/app/src/main/java/com/google/samples/quickstart/config/kotlin/MainComposeActivity.kt
Outdated
Show resolved
Hide resolved
Added initial PR changes that Rosário had mentioned.
Combined the text and button into the parent composable function
Updated the MainComposeActivity.kt to remove the wildcard imports and replaced with the appropriate ones
Corrected exceeded max line length error by putting the comment under the code. Corrected build.gradle code to have proper syntax
thatfiredev
reviewed
Jan 27, 2023
config/app/src/main/java/com/google/samples/quickstart/config/kotlin/MainComposeActivity.kt
Outdated
Show resolved
Hide resolved
Updated MainComposeAcitvity.kt to correct lint error
A couples of things happened here: - Renamed `fetchConfig()` to `fetchRemoteConfig()` - Created ViewModel Factory to help inject VM dependencies - Moved FirebaseRemoteConfig initialization to the ViewModel (The UI now calls these methods when the screen is created, through a DisposableEffect) - The default value from the XML file is now shown when the screen is first shown
Restructured the UI by implementing Scaffold
Added scaffold and fillMaxWidth imports. Currently having issues with the Scaffold and the experimental wanting it to use wildcard statements
Migrated the code from Material 3 to 2. Also updated Gradle file to use Compose 1.3
Added snackbar when config button is pressed.
thatfiredev
reviewed
Feb 10, 2023
config/app/src/main/java/com/google/samples/quickstart/config/kotlin/MainComposeActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review by Rosário Fernandes
Created an option to use Config using Jetpack Compose.
Viewmodels is the next step to be implemented to this Quickstart rather than having the FirebaseActivity file.
In the MainComposeActivity file that was created, please review Composables to advise on whether to continue passing Lambdas or if a Context would be better suitable in this scenario to pass.