Skip to content

chore(docs): encode does not accept objects #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

t-richard
Copy link

@t-richard t-richard commented Sep 23, 2022

This PHP doc sentence is misleading in regards to the actual PHPdoc and typehint.

@google-cla
Copy link

google-cla bot commented Sep 23, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer bshaffer changed the title Encode does not accept objects chore(docs): encode does not accept objects Oct 5, 2022
@bshaffer bshaffer merged commit f7886d5 into firebase:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants