-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow composer to choose the latest phpunit major version matching each PHP version #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow composer to choose the latest phpunit major version matching each PHP version #277
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
8cc6552
to
9d96ae8
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just a few suggestions...
@bschaffer let me know if you want me to squash the commits. |
22fe197
to
efc04f9
Compare
Squashed and CI passing. |
It is possible to run with the latest
phpunit
that goes with each version of PHP.To keep supporting the very old versions of PHP and
phpunit
I had to add some version checks in the unit tests to choose whether to usesetExpectedException
orexpectException
. That could also probably be done withmethod_exists
What do you think about this approach, using modern versions of
phpunit
where we can?