Skip to content

Allow composer to choose the latest phpunit major version matching each PHP version #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

phil-davis
Copy link

@phil-davis phil-davis commented Mar 11, 2020

It is possible to run with the latest phpunit that goes with each version of PHP.
To keep supporting the very old versions of PHP and phpunit I had to add some version checks in the unit tests to choose whether to use setExpectedException or expectException. That could also probably be done with method_exists

What do you think about this approach, using modern versions of phpunit where we can?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@phil-davis phil-davis force-pushed the allow-matching-phpunit-major-version branch from 8cc6552 to 9d96ae8 Compare March 11, 2020 11:43
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@phil-davis phil-davis marked this pull request as ready for review March 11, 2020 11:55
Copy link
Collaborator

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a few suggestions...

@phil-davis phil-davis requested a review from bshaffer March 13, 2020 03:51
@phil-davis
Copy link
Author

@bschaffer let me know if you want me to squash the commits.

@phil-davis phil-davis force-pushed the allow-matching-phpunit-major-version branch from 22fe197 to efc04f9 Compare March 14, 2020 09:01
@phil-davis
Copy link
Author

Squashed and CI passing.

@phil-davis phil-davis requested a review from bshaffer March 14, 2020 09:08
@bshaffer bshaffer merged commit 51034b4 into firebase:master Mar 16, 2020
@phil-davis phil-davis deleted the allow-matching-phpunit-major-version branch March 16, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants