Skip to content

Use json_last_error without unnecessary existence check #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

Krisell
Copy link

@Krisell Krisell commented Dec 1, 2019

json_last_error() was introduced in PHP 5.3.0, which is a requirement for this package. Hence, the existence check is no longer needed.

@bshaffer bshaffer merged commit 20f3729 into firebase:master Dec 17, 2019
@bshaffer
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants