Skip to content

Conversation

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented May 14, 2018

Fixes #114.

@mcdonamp PTAL

Podfile.lock Outdated
@@ -0,0 +1,37 @@
PODS:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want to include the Podfile.lock? I assume not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@asciimike asciimike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Podfile.lock otherwise LGTM

@ghost
Copy link

ghost commented May 27, 2018

@morganchen12 Can you or anyone else merge this please? Thanks!

@asciimike
Copy link
Contributor

@ghowen sorry, I think this was on me. Merging and will deploy shortly.

@asciimike asciimike closed this May 27, 2018
@asciimike asciimike merged commit 7bc124d into firebase:master May 27, 2018
@asciimike
Copy link
Contributor

Ok, 3.0.0 is out the door in CocoaPods.

@ghost
Copy link

ghost commented May 27, 2018

Great, thanks! I already switched back to
pod 'GeoFire', :git => 'https://github.com/firebase/geofire-objc.git'
and it works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants