Update location with updateChildValues

[RaMin0]

Use updateChildValues (and setPriority) in favor of setValuesAndPriority to avoid overwriting other child values.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[RaMin0]

I signed it!

[googlebot]

CLAs look good, thanks!

[morganchen12]

@mcdonamp please review

[asciimike]

@RaMin0 @morganchen12 it looks like we don't actually need priority (we store the geohash in g and query by that, rather than priority), so I'd just remove the code and tests for priority and use update, no need to do the second update.

Presumably this is so you can store additional data alongside the GeoFire info?

[RaMin0]

@mcdonamp: Presumably this is so you can store additional data alongside the GeoFire info

Yes, it made more sense to save the related info stored in the same node rather than having a parallel node that I have to maintain just to keep the extra info.

One other thing I suggest to do is to make the name of the location key (currently l) configurable, to give more context. pickUpLocation is more significant than just l. But that's an issue for another PR.

[RaMin0]

@mcdonamp Check 96f4043.

[asciimike]

Please instead test g rather than priority. We'd like to make sure everything still works :)

[RaMin0]

Isn't it already tested on the previous line when comparing the whole value of the snapshot?

[asciimike]

Derp, yes.