Skip to content

fix: fix up invalid tsconfig shipped on npm #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: fix up invalid tsconfig shipped on npm #2973

wants to merge 4 commits into from

Conversation

gioboa
Copy link

@gioboa gioboa commented May 27, 2025

This commit ignore extra files in the npm publication and removes red highlight in VSCode for node_modules.

ISSUE: #2932

Checklist (if applicable):

@gioboa
fix: fix up invalid tsconfig shipped on npm
b1f24d2 
This commit adds new files to npm ingnore.
This removes red highlight in VSCode for node_modules.

ISSUE: firebase#2932
@gioboa
Copy link
Author

gioboa commented May 27, 2025 •
edited
Loading

I fixed up all the problematic packages.
Usually it's a best practice to remove src folder as well. Do we want to publish them too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config fix js tooling
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gioboa