feat(go/plugins/googlegenai)!: use go-genai SDK configuration
#2958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoaguirre
changed the title
go-genai SDK configuration
apascal07
requested changes
May 27, 2025
go/plugins/googlegenai/gemini.go
Outdated
| @@ -39,6 +40,9 @@ import ( | |||
| "google.golang.org/genai" | |||
| ) | |||
|
|
|||
| // Plugin configuration alias | |||
| type GeminiConfig = genai.GenerateContentConfig | |||
There was a problem hiding this comment.
I think let's omit this for now because we would probably want aliases for all the types, not just the top level... at which point I'm not sure it's worth it.
hugoaguirre
commented
May 27, 2025
|
|
||
| // Genkit primitive fields must be used instead of go-genai fields | ||
| // i.e.: system prompt, tools, cached content, response schema, etc | ||
| if gcc.SystemInstruction != nil { |
There was a problem hiding this comment.
@apascal07, here's where we validate the user request message do not set Genkit native features. I've added:
- System prompts
- Tools (just for function declaration tools, but kept the ability to support Code Execution, Google Search and so on)
- Cached contents
- Response schema
- Response mime type
hugoaguirre
force-pushed
the
haguirre/generic-config
branch
from
f34a722 to
2202be9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of
googlegenai.GeminiConfigand usegenai.GenerateContentConfiginsteadChecklist (if applicable):