Skip to content

feat(go/plugins/googlegenai)!: use go-genai SDK configuration #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 12, 2025
Merged

feat(go/plugins/googlegenai)!: use go-genai SDK configuration #2958

merged 12 commits into from
Jun 12, 2025

Conversation

hugoaguirre
Copy link
Contributor

@hugoaguirre hugoaguirre commented May 22, 2025 •
edited
Loading

Remove the usage of googlegenai.GeminiConfig and use genai.GenerateContentConfig instead

Checklist (if applicable):

@github-actions github-actions bot added the go label May 22, 2025
@hugoaguirre hugoaguirre changed the title feat(go/plugins/googlegenai): use go-genai sdk configuration feat(go/plugins/googlegenai)!: use go-genai SDK configuration May 22, 2025
@hugoaguirre hugoaguirre marked this pull request as ready for review May 26, 2025 18:52
@hugoaguirre hugoaguirre requested a review from apascal07 May 26, 2025 18:52
apascal07
apascal07 requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were also going to add errors if certain config fields were set that are native Genkit features, no?

hugoaguirre
hugoaguirre commented May 27, 2025
View reviewed changes
@hugoaguirre hugoaguirre requested a review from apascal07 May 27, 2025 20:55
@hugoaguirre hugoaguirre force-pushed the haguirre/generic-config branch from f34a722 to 2202be9 Compare May 27, 2025 22:05
@hugoaguirre hugoaguirre enabled auto-merge (squash) June 9, 2025 18:16
@hugoaguirre hugoaguirre disabled auto-merge June 11, 2025 21:02
@apascal07 apascal07 merged commit 03a5127 into main Jun 12, 2025
7 checks passed
@apascal07 apascal07 deleted the haguirre/generic-config branch June 12, 2025 17:02
hendrixmar pushed a commit that referenced this pull request Jun 12, 2025
@hugoaguirre @hendrixmar
feat(go/plugins/googlegenai)!: use go-genai SDK configuration (#2958)
ef24710
@hugoaguirre hugoaguirre mentioned this pull request Jun 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apascal07 apascal07 apascal07 approved these changes

Assignees
No one assigned
Labels
go
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugoaguirre @apascal07