Skip to content

Conversation

@nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented Jul 20, 2022

Description

7ba3141 has broken the CI. This PR should fix it.

ToDo:

  • Moved firebase_dynamic_links into own workflow (just skipping the test for now like it's done in the driver tests)

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the type: infrastructure Improvements to the codebase label Jul 22, 2022
@nilsreichardt
Copy link
Contributor Author

I think it makes sense to just merge this PR (it just a PR for a feature branch), merge the master again into migrate-to-integration-test and then fix again the remaining issues.

@russellwheatley russellwheatley marked this pull request as ready for review August 22, 2022 08:35
@russellwheatley russellwheatley merged commit f9250b1 into firebase:migrate-to-integration-tests Aug 22, 2022
@firebase firebase locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: infrastructure Improvements to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants