Skip to content

fix(ui): validate email with the library instead of the RegExp #7772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix(ui): validate email with the library instead of the RegExp #7772

merged 1 commit into from
Jan 4, 2022

Conversation

lesnitsky
Copy link
Member

@lesnitsky lesnitsky commented Jan 4, 2022 •
edited by Salakar
Loading

Description

This PR changes the RegExp based email validator to email_validator package

Related Issues

Closes #7761
Closes #7680

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@lesnitsky lesnitsky requested a review from Salakar January 4, 2022 15:03
@Salakar Salakar merged commit b271b7f into master Jan 4, 2022
@Salakar Salakar deleted the fix/validate-email-with-lib branch January 4, 2022 15:30
@firebase firebase locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lesnitsky @Salakar