Skip to content

Conversation

russellwheatley
Copy link
Member

Description

DataSnapshot is always returned from a get() request.
DataSnapshot.exists ascertains whether value exists at RTDB location.

Related Issues

fixes #6747

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Aug 3, 2021
@russellwheatley russellwheatley merged commit 3c97480 into master Aug 3, 2021
@russellwheatley russellwheatley deleted the @russell/rtdb-exists-check branch August 3, 2021 09:49
@firebase firebase locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_database] RTDB get() call should return Future<DataSnapshot> instead of Future<DataSnapshot?>
3 participants