Skip to content

fix(cloud_firestore): conditionally pass options to docChanges #5751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Apr 13, 2021

Description

Since version 8.0.2 of the Firestore web sdk, it seems passing null to docChanges causes the underlying SDK to assume the user passed options, which causes a "null pointer exception".

This change wraps the options check, and doesn't pass arguments (undefined) instead.

Line of code: https://github.com/firebase/firebase-js-sdk/blob/626c05b36cfe7f91ac9b6aad730c0f04d6bb8c01/packages/firestore/src/exp/snapshot.ts#L445

Related Issues

Fixes #4127

Unblocks #5170

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Apr 13, 2021
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehardy
Copy link
Contributor

Yes! This un blocks current js sdks and makes using all of the Auth emulator stuff official. Exciting!

@Salakar Salakar merged commit 9e349a9 into master Apr 13, 2021
@Salakar Salakar deleted the @ehesp/fix-4127 branch April 13, 2021 15:39
@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore_web] Collection get throws Error: [cloud_firestore/unknown] NoSuchMethodError: invalid member on null: 'includeMetadataChanges'
4 participants