Skip to content

fix[firebase_ml_vision]: Migrate to sound null safety #5490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

alxflam
Copy link

@alxflam alxflam commented Mar 26, 2021

Description

Migrate ml_vision to sound null safety.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [-] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Bumped major version to 1.0.0 due to sound null safety support.

@google-cla
Copy link

google-cla bot commented Mar 26, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 26, 2021
@alxflam alxflam changed the title [firebase_ml_vision] Migrate to sound null safety fix[firebase_ml_vision] Migrate to sound null safety Mar 26, 2021
@alxflam alxflam changed the title fix[firebase_ml_vision] Migrate to sound null safety fix[firebase_ml_vision]: Migrate to sound null safety Mar 26, 2021
@alxflam
Copy link
Author

alxflam commented Mar 26, 2021

Just seen PR #5474 also addresses this issue. Therefore closing this PR.

@alxflam alxflam closed this Mar 26, 2021
@firebase firebase locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant