Skip to content

feat!: Migrate firebase_dynamic_links to sound null safety #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 25, 2021

Conversation

AlexHartford
Copy link
Contributor

Description

This PR updates firebase dynamic links to sound null safety.

The primary uncertainty is integration_test package consuming e2e. It appears flutter_driver is holding packages back. It also appeared in other null-safe releases of other flutterfire packages (e.g., firebase_core), the integration tests were removed (not sure if this is a temporary measure or not). Hence, I followed suit and removed the dependency on e2e & flutter_driver.

Related Issues

#4182

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Mar 16, 2021
@AlexHartford AlexHartford changed the title refactor: Migrate firebase dynamic links to sound null safety refactor: Migrate firebase_dynamic_links to sound null safety Mar 16, 2021
@Salakar Salakar requested a review from rrousselGit March 16, 2021 21:56
@Salakar
Copy link
Member

Salakar commented Mar 16, 2021

cc @rrousselGit - would you mind reviewing this one, thanks!

@rrousselGit rrousselGit changed the title refactor: Migrate firebase_dynamic_links to sound null safety feat!: Migrate firebase_dynamic_links to sound null safety Mar 24, 2021
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 24, 2021
@rrousselGit
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 24, 2021
@rrousselGit
Copy link
Contributor

The code looks good, but I'm confused as to why the CI doesn't start properly.

Copy link
Contributor

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this is expected. LGTM then!

@rrousselGit rrousselGit merged commit fd0f4eb into firebase:master Mar 25, 2021
@AlexHartford AlexHartford deleted the dynamic-links-nullsafety branch March 25, 2021 14:56
@firebase firebase locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants