-
Notifications
You must be signed in to change notification settings - Fork 4k
feat!: Migrate firebase_dynamic_links to sound null safety #5368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Migrate firebase_dynamic_links to sound null safety #5368
Conversation
cc @rrousselGit - would you mind reviewing this one, thanks! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
The code looks good, but I'm confused as to why the CI doesn't start properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that this is expected. LGTM then!
Description
This PR updates firebase dynamic links to sound null safety.
The primary uncertainty is integration_test package consuming e2e. It appears flutter_driver is holding packages back. It also appeared in other null-safe releases of other flutterfire packages (e.g., firebase_core), the integration tests were removed (not sure if this is a temporary measure or not). Hence, I followed suit and removed the dependency on e2e & flutter_driver.
Related Issues
#4182
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?