chore: enable lints in firebase_performance #5253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrousselGit
force-pushed
the
performance-lint
branch
2 times, most recently
from
5689192 to
8314764
Compare
mikehardy
reviewed
Mar 7, 2021
| # the new lints that are already failing on this plugin, for this plugin. It | ||
| # should be deleted and the failing lints addressed as soon as possible. | ||
|
|
||
| include: ../../analysis_options.yaml |
There was a problem hiding this comment.
silly question probably, but why (if the all_lint_rules.yaml and analysis_options.yaml are effectively boilerplate duplicated amongst packages) don't they just refer to a common file in firebase_core or similar?
There was a problem hiding this comment.
The goal is, after these PRs are merged, I'll make a separate PR fusing all the duplicates in a single file at the root of the repo
There was a problem hiding this comment.
makes sense as a pragmatic approach, I was sincerely just curious. Thanks @rrousselGit
rrousselGit
force-pushed
the
performance-lint
branch
from
8314764 to
8ddab68
Compare
rrousselGit
force-pushed
the
performance-lint
branch
from
87fbef8 to
86f7280
Compare
|
Merging since apparently the CI fail is not caused by this PR cc @mikehardy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add extra lints for firebase_performance
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?