Skip to content

refactor(firestore)!: migrate to NNBD #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Feb 2, 2021

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jan 22, 2021

Description

Firestore NNBD (null-safety) migration.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Jan 22, 2021
@russellwheatley russellwheatley changed the title @russell/nnbd firestore migration refactor(firestore): nnbd firestore migration Jan 22, 2021
@Salakar
Copy link
Member

Salakar commented Feb 1, 2021

Some leftover asserts also:

info: The operand can't be null, so the condition is always true. (unnecessary_null_comparison at [cloud_firestore] lib/src/collection_reference.dart:46)
info: The operand can't be null, so the condition is always true. (unnecessary_null_comparison at [cloud_firestore] lib/src/query.dart:56)

@Salakar Salakar changed the title refactor(firestore)!: nnbd firestore migration refactor(firestore)!: migrate to NNBD Feb 2, 2021
@Salakar Salakar merged commit 4cb2bc3 into master Feb 2, 2021
@Salakar Salakar deleted the @russell/nnbd-firestore-migration branch February 2, 2021 17:09
@fabriziocacicia
Copy link

Maybe the package version in the pubspec.yaml should be updated?

@Salakar
Copy link
Member

Salakar commented Feb 3, 2021

Maybe the package version in the pubspec.yaml should be updated?

This is done automatically on master on publish.

@firebase firebase locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants