-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(macos)!: macOS build failures (fixes #4628) #4634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…from firebase_core, or be user defined.
Visit the preview URL for this PR (updated for commit 2a97815): https://flutter-firebase-docs--pr4634-salakar-firestore-a-fqg5avib.web.app (expires Tue, 19 Jan 2021 14:42:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
packages/firebase_storage/firebase_storage/macos/firebase_storage.podspec
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits on the repetitiveness of the ruby, seems like could be firebase_core functionality to honor DRY principle, but things look reasonable. Having bite-size commits made it easy to roll through for review +1 on that
Sometimes fails with `[firebase_storage/unknown] An unknown error occurred, please check the server response.`.
Description
Related Issues
Fixes #4628
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?