Skip to content

fix(macos)!: macOS build failures (fixes #4628) #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 12, 2021

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented Jan 12, 2021

Description

  • Adds missing file symlinks that weren't picked up before merging feat(cloud_firestore): Move Snapshot handling into a EventChannel #4209 as CI was disabled (this PR also re-enables it to see if the issue has resolved itself).
  • Bumps all example apps to explicitly target osx 10.12.
  • Adds a quick ruby script to each macOS podspec to give a better log output with solutions on how to fix for users who are not on 10.12 or later deployment target for osx (Flutter default is currently 10.11) (note I just did a quick 'equals to' check on the version just to cover the most common case for ease).

Related Issues

Fixes #4628

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@github-actions
Copy link

github-actions bot commented Jan 12, 2021

Visit the preview URL for this PR (updated for commit 2a97815):

https://flutter-firebase-docs--pr4634-salakar-firestore-a-fqg5avib.web.app

(expires Tue, 19 Jan 2021 14:42:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Salakar Salakar changed the title fix(firestore,macos): add missing symlinks (fixes #4628) fix(firestore,macos)!: macOS build failures (fixes #4628) Jan 12, 2021
@Salakar Salakar changed the title fix(firestore,macos)!: macOS build failures (fixes #4628) fix(macos)!: macOS build failures (fixes #4628) Jan 12, 2021
@Salakar Salakar added impact: critical Usually a production crash with high user impact. (P1) platform: macos Issues / PRs which are specifically for MacOS. severe: regression labels Jan 12, 2021
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits on the repetitiveness of the ruby, seems like could be firebase_core functionality to honor DRY principle, but things look reasonable. Having bite-size commits made it easy to roll through for review +1 on that

Sometimes fails with `[firebase_storage/unknown] An unknown error occurred, please check the server response.`.
@Salakar Salakar marked this pull request as ready for review January 12, 2021 14:49
@Salakar Salakar requested a review from kroikie as a code owner January 12, 2021 14:49
@Salakar Salakar merged commit cdd58f1 into master Jan 12, 2021
@Salakar Salakar deleted the @salakar/firestore-and-ci-fixes branch January 12, 2021 15:58
@firebase firebase locked and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes impact: critical Usually a production crash with high user impact. (P1) platform: macos Issues / PRs which are specifically for MacOS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore plugin compilation fails because of missing header files
2 participants