Skip to content

refactor(firestore_auth)!: remove deprecated APIs #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

russellwheatley
Copy link
Member

Description

Remove deprecated firestore_auth API ahead of the next major release.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Jan 7, 2021
@russellwheatley russellwheatley changed the title chore(firestore_auth): rm deprecated code refactor(firestore_auth)!: rm deprecated code Jan 7, 2021
@Salakar Salakar changed the title refactor(firestore_auth)!: rm deprecated code refactor(firestore_auth)!: remove deprecated APIs Jan 7, 2021
@russellwheatley russellwheatley marked this pull request as ready for review January 7, 2021 16:48
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salakar Salakar merged commit 0296576 into master Jan 7, 2021
@Salakar Salakar deleted the @russell/auth-rm-deprecations branch January 7, 2021 18:04
jfri added a commit to jfri/flutterfire that referenced this pull request Jan 21, 2021
@firebase firebase locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants