Skip to content

fix(messaging,ios): do not suppress forwarded local notifications - #18701

Open
SelaseKay wants to merge 2 commits into
mainfrom
messaging_18699
Open

SelaseKay wants to merge 2 commits into
mainfrom
messaging_18699

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

On iOS, willPresentNotification called the shared completion handler with UNNotificationPresentationOptionNone whenever this plugin had not replaced another delegate. UIScene apps that assign UNUserNotificationCenter.delegate to AppDelegate forward that callback to every plugin. Messaging answering None hid foreground banners posted by other plugins, including flutter_local_notifications, after 16.7.0.

The handler is now called only when:

  • another delegate was replaced and must receive the callback, or
  • this plugin is the notification center delegate, or
  • Flutter forwarded a remote FCM notification (aps and gcm.message_id) and the app opted into foreground presentation via setForegroundNotificationPresentationOptions.

A forwarded local notification is left for the plugin that posted it. The same split is applied to didReceiveNotificationResponse so a tap on that local notification is not consumed. APNs registration from #18620 is unchanged.

Related Issues

Fixes #18699

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

willPresentNotification answered UNNotificationPresentationOptionNone for every
notification when AppDelegate owned the notification center, which hid banners
posted by other plugins.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

A forwarded remote notification must call the completion handler even when the app has not opted into presentation, so the banner stays hidden and iOS is not left waiting.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked: do-not-merge PR blocked externally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_messaging][iOS] 16.7.0 breaks foreground notifications posted by other plugins on UIScene apps that own the UNUserNotificationCenter delegate

2 participants