Skip to content

Commit 46f04bc

Browse files
Cleanup and some fixes
1 parent 3de47cf commit 46f04bc

File tree

7 files changed

+11
-12
lines changed

7 files changed

+11
-12
lines changed

packages/firebase_data_connect/firebase_data_connect/lib/firebase_data_connect.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,5 @@ export 'src/optional.dart'
3939
listDeserializer,
4040
listSerializer;
4141
export 'src/timestamp.dart' show Timestamp;
42-
export 'src/cache/cache_data_types.dart' show CacheSettings, QueryFetchPolicy, CacheStorage;
42+
export 'src/cache/cache_data_types.dart'
43+
show CacheSettings, QueryFetchPolicy, CacheStorage;

packages/firebase_data_connect/firebase_data_connect/lib/src/cache/cache_manager.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ import 'dart:developer' as developer;
1818
import 'package:firebase_auth/firebase_auth.dart';
1919
import 'package:firebase_data_connect/firebase_data_connect.dart';
2020
import 'cache_provider.dart';
21-
import 'in_memory_cache_provider.dart' if (dart.library.io) 'sqlite_cache_provider.dart';
21+
import 'in_memory_cache_provider.dart'
22+
if (dart.library.io) 'sqlite_cache_provider.dart';
2223

2324
import '../common/common_library.dart';
2425

@@ -110,8 +111,6 @@ class Cache {
110111

111112
Set<String> impactedQueryIds = dehydrationResult.impactedQueryIds;
112113
impactedQueryIds.remove(queryId); // remove query being cached
113-
print(
114-
'adding to impactedQueryController ${dehydrationResult.impactedQueryIds}');
115114
_impactedQueryController.add(impactedQueryIds);
116115
}
117116

packages/firebase_data_connect/firebase_data_connect/lib/src/cache/in_memory_cache_provider.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ class InMemoryCacheProvider implements CacheProvider {
3131

3232
@override
3333
Future<bool> initialize() async {
34-
// nothing to be intialized
35-
print('Initialize inmemory provider called');
34+
// nothing to be intialized.
3635
return true;
3736
}
3837

@@ -55,7 +54,6 @@ class InMemoryCacheProvider implements CacheProvider {
5554
EntityDataObject getEntityDataObject(String guid) {
5655
EntityDataObject? edo = _edos[guid];
5756
if (edo != null) {
58-
print('Returning existing edo for $guid');
5957
return edo;
6058
} else {
6159
edo = EntityDataObject(guid: guid);
@@ -76,4 +74,5 @@ class InMemoryCacheProvider implements CacheProvider {
7674
}
7775
}
7876

79-
CacheProvider cacheImplementation(String identifier, bool memory) => InMemoryCacheProvider(identifier);
77+
CacheProvider cacheImplementation(String identifier, bool memory) =>
78+
InMemoryCacheProvider(identifier);

packages/firebase_data_connect/firebase_data_connect/lib/src/cache/sqlite_cache_provider.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,4 +126,5 @@ class SQLite3CacheProvider implements CacheProvider {
126126
}
127127
}
128128

129-
CacheProvider cacheImplementation(String identifier, bool memory) => SQLite3CacheProvider(identifier, memory: memory);
129+
CacheProvider cacheImplementation(String identifier, bool memory) =>
130+
SQLite3CacheProvider(identifier, memory: memory);

packages/firebase_data_connect/firebase_data_connect/lib/src/core/ref.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ class QueryManager {
146146
if (dataConnect.cacheManager != null) {
147147
_impactedQueriesSubscription =
148148
dataConnect.cacheManager!.impactedQueries.listen((impactedQueryIds) {
149-
print('impactedQueries received updated $impactedQueryIds');
150149
for (final queryId in impactedQueryIds) {
151150
final queryParts = queryId.split('-');
152151
final queryName = queryParts[0];

packages/firebase_data_connect/firebase_data_connect/lib/src/firebase_data_connect.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class FirebaseDataConnect extends FirebasePluginPlatform {
186186

187187
if (cachedInstances[app.name] != null &&
188188
cachedInstances[app.name]![connectorConfig.toJson()] != null) {
189-
print('Returning cached FirebaseDataConnect instance');
189+
print('Returning cached FirebaseDataConnect instance');
190190
return cachedInstances[app.name]![connectorConfig.toJson()]!;
191191
}
192192

packages/firebase_data_connect/firebase_data_connect/test/src/cache/cache_manager_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ void main() {
9393
dataConnect = FirebaseDataConnect(
9494
app: mockApp,
9595
connectorConfig: mockConnectorConfig,
96-
cacheSettings: const CacheSettings(storage: CacheStorage.memory));
96+
cacheSettings: CacheSettings(storage: CacheStorage.memory));
9797
dataConnect.checkTransport();
9898
dataConnect.checkAndInitializeCache();
9999
});

0 commit comments

Comments
 (0)