CacheSettings constructor feedback from Cynthia

Author: aashishpatil-g

packages/firebase_data_connect/firebase_data_connect/lib/src/cache/cache_data_types.dart

@@ -33,10 +33,26 @@ class CacheSettings {
   /// Duration for which cache is used before revalidation with server
   final Duration maxAge;
 
-  const CacheSettings(
-      {this.storage = kIsWeb ? CacheStorage.memory : CacheStorage.persistent,
-      this.maxSizeBytes = kIsWeb ? 40000000 : 100000000,
-      this.maxAge = Duration.zero});
+  // Internal const constructor
+  const CacheSettings._internal({
+    required this.storage,
+    required this.maxSizeBytes,
+    required this.maxAge,
+  });
+
+  // Factory constructor to handle the logic
+  factory CacheSettings({
+    CacheStorage? storage,
+    int? maxSizeBytes,
+    Duration maxAge = Duration.zero,
+  }) {
+    return CacheSettings._internal(
+      storage:
+          storage ?? (kIsWeb ? CacheStorage.memory : CacheStorage.persistent),
+      maxSizeBytes: maxSizeBytes ?? (kIsWeb ? 40000000 : 100000000),
+      maxAge: maxAge,
+    );
+  }
 }
 
 /// Enum to control the fetch policy for a query

packages/firebase_data_connect/firebase_data_connect/lib/src/firebase_data_connect.dart

@@ -179,7 +179,7 @@ class FirebaseDataConnect extends FirebasePluginPlatform {
       FirebaseAppCheck? appCheck,
       CallerSDKType? sdkType,
       required ConnectorConfig connectorConfig,
-      CacheSettings? cacheSettings = const CacheSettings()}) {
+      CacheSettings? cacheSettings}) {
     app ??= Firebase.app();
     auth ??= FirebaseAuth.instanceFor(app: app);
     appCheck ??= FirebaseAppCheck.instanceFor(app: app);
@@ -190,6 +190,9 @@ class FirebaseDataConnect extends FirebasePluginPlatform {
       return cachedInstances[app.name]![connectorConfig.toJson()]!;
     }
 
+    //TODO remove after testing since CS should be null by default
+    cacheSettings = cacheSettings ?? CacheSettings();
+
     FirebaseDataConnect newInstance = FirebaseDataConnect(
       app: app,
       auth: auth,