Skip to content

Porting over some Github Actions fixes from the v9 PR #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Sep 29, 2021

Cleanup and fixes for the recent webdriver-manager break.

  • Only build "on push" on the main branch, this prevent double runs from triggering on PRs
  • webdriver-manager defaults to the latest version of chrome, which isn't on github actions yet. This is resulting in the tests failing. Clean up the handling here and pin to the installed version of google-chrome (falling back to latest)
  • our build script would recurse... 🤦 don't retrigger build in the generate_test_files.sh, there's also no clean task so dropping that
  • use the saucelabs readyfile, since tests are tripping before the socket is established
  • upgrade sc again and add OSX support to sauce_connect.sh
  • run the local tests first before tripping saucelabs, so it's quicker and easier to tell what tests are red

@jamesdaniels jamesdaniels requested a review from xil222 October 1, 2021 19:36
@xil222 xil222 merged commit a3edcd5 into master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants