Skip to content

Add types property to package #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add types property to package #149

wants to merge 1 commit into from

Conversation

ShaMan123
Copy link

This exposes types for the compiler
Continues #48

This exposes types for the compiler
Continues #48
@landsman
Copy link

nice!

@jhuleatt
Copy link
Contributor

Thanks @ShaMan123!

@jamesdaniels this looks like a helpful fix to me, but wanted to double check with you before merging.

@landsman
Copy link

landsman commented Dec 6, 2021

pls 🙏

@jhuleatt
Copy link
Contributor

jhuleatt commented Dec 6, 2021

After looking into this a bit more and chatting with @jamesdaniels , we are shipping an index.d.ts (which Typescript looks for implicitly), and in a test project I was able to get the types as-is, without the need for a types field.

I'm going to close this out, but if I'm misunderstanding, please comment and we can discuss.

@jhuleatt jhuleatt closed this Dec 6, 2021
@landsman
Copy link

landsman commented Dec 7, 2021

@jhuleatt Can you say future version number with this pls?

@jhuleatt
Copy link
Contributor

jhuleatt commented Dec 7, 2021

The latest version on npm, 6.0.0, has types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants