Skip to content

React strict mode compatibility #184

Closed
@jwhiting

Description

@jwhiting

As surfaced in #59, the FirebaseAuth and StyledFirebaseAuth components are not React strict-mode compatible. In particular both of these components fail to render and throw Error: AuthUI instance is deleted!

Unfortunately, React does not currently offer a way for any part of a strict-mode component tree to opt-out of strict mode (per facebook/react#16362), so the only solution for people using this library appears to be turning strict mode off entirely, or going to great lengths to try to wrap the parts of the tree that do not include this component in strict-mode wrappers, which is extremely error-prone.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions