Skip to content

tvOS metadata files #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 28, 2022
Merged

tvOS metadata files #476

merged 9 commits into from
Sep 28, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Sep 26, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Update the build scripts to produce tvOS .unitypackage files containing tvOS metadata files and fat library support for devices and simulators.

Removed the export of `"libCrashlyticsiOSWrapper.a" which doesn't seem to be produced by the build system since we've moved to cmake. Instead the symbols are part of the standard Crashlytic libraires on iOS and tvOS.


Testing

Describe how you've tested these changes.

  • Executed scripts locally.
  • Created unitypackages with a subset of platforms, and with all of the platforms supported by macOS builds (iOS, Android, macOS, tvOS).
  • Imported the unitypackages into the Unity version 2020 and 2021 LTS.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@DellaBitta DellaBitta added the tests-requested: quick Trigger a quick set of integration tests. label Sep 26, 2022
@DellaBitta DellaBitta marked this pull request as ready for review September 26, 2022 17:34
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 26, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 26, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 26, 2022
@DellaBitta DellaBitta removed the tests: failed This PR's integration tests failed. label Sep 28, 2022
@firebase firebase deleted a comment from github-actions bot Sep 28, 2022
@DellaBitta DellaBitta merged commit 47295d3 into main Sep 28, 2022
@DellaBitta DellaBitta deleted the feature/tvos_metadata_files branch September 28, 2022 21:32
@DellaBitta DellaBitta changed the title Feature/tvos metadata files tvOS metadata files Oct 5, 2022
@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants