Build other editor libraries #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create `Editor/Firebase.<ComponentName>.Editor.dll` for Analytics, Auth, Crashlytics, Dynamic Links and Messaging.
Just a typo.
cynthiajoan
reviewed
Jul 12, 2021
| add_subdirectory(analytics) | ||
| add_subdirectory(auth) | ||
| # TODO(cl/383898177): Waiting for this cl to be synced to Github repo. | ||
| # add_subdirectory(crashlytics) |
There was a problem hiding this comment.
Do you comment this out purposely?
There was a problem hiding this comment.
Yes. Still waiting for Crashlytics team review, and copybara.
That can take awhile so just push the changes for other libraries.
|
Could you provide instructions to build and test this in the PR description? |
cynthiajoan
approved these changes
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed
.gitignore