Update find mono scripts #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
approved these changes
Jun 7, 2021
vimanyu
approved these changes
Jun 8, 2021
Contributor
vimanyu
left a comment
vimanyu
left a comment
There was a problem hiding this comment.
Looks good except a minor note on more descriptive error message.
| SET MONO_DIR="C:/Program Files (x86)/Mono/bin" | ||
| ) ELSE ( | ||
| ECHO ERROR: Cant find mono | ||
| ECHO ERROR: Cant find mono in programs files x86 |
Contributor
There was a problem hiding this comment.
Since we are being more specific with the error here, as a user, it will be awesome to see something like this,
"Can't find mono in C:\Program Files (x86)".
Contributor
Author
There was a problem hiding this comment.
I tried somehow the .bat file doesn't like it....
| SET MONO_DIR="C:/Program Files/Mono/bin" | ||
| ) ELSE ( | ||
| ECHO ERROR: Cant find mono | ||
| ECHO ERROR: Cant find mono in program files |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.