Updated init for Storage to download rules from gcp

[lemonjacob]

Description

Matched the functionality of the firestore init command. When using init with the storage feature it now pulls the latest published version of your storage rules just like firestore. I added unit tests to verify this functionality.

Scenarios Tested

Tested on a few of my current projects when running the firebase init storage command

Sample Commands

firebase init storage

[gemini-code-assist]

Summary of Changes

Hello @lemonjacob, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the firebase init storage command by integrating the capability to download existing Storage Security Rules directly from the Firebase console. This change ensures that when a user initializes Storage, their local configuration can be pre-populated with the most current rules deployed in their project, providing a more consistent and streamlined setup experience.

Highlights

• Storage Rules Download: The firebase init storage command now automatically downloads the latest published Storage Security Rules from the Firebase console, mirroring the functionality of the Firestore initialization process.
• New Helper Function: A new asynchronous helper function, getRulesFromConsole, has been introduced to handle the logic of fetching the latest Storage ruleset name and its content from Google Cloud Platform.
• Unit Test Coverage: New unit tests have been added to storage.spec.ts to ensure the correct behavior of downloading rules from the console during the initialization flow.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the firebase init storage command by adding functionality to download existing storage rules from the Firebase console, which brings it in line with the behavior of firebase init firestore. The implementation is sound and includes a new unit test to cover the added functionality. My review includes a few suggestions to improve code documentation by filling in empty JSDoc blocks and to enhance code clarity by refining a conditional check. Overall, these are solid improvements that enhance feature consistency.