-
Notifications
You must be signed in to change notification settings - Fork 1.1k
use mcp logger API #9434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
use mcp logger API #9434
Conversation
Summary of ChangesHello @antholeole, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the logging mechanism within the MCP server and its associated utilities. The primary goal is to standardize debug logging by transitioning from a custom Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors the codebase to adopt the new MCP logger API. By replacing direct calls to this.log with the new this.logger methods and making the log method private, it enforces the use of the new API and improves the overall logging implementation. The changes are consistent and well-executed. I have included a couple of minor suggestions to enhance code formatting and maintain consistency.
src/mcp/index.ts
Outdated
| async detectActiveFeatures(): Promise<ServerFeature[]> { | ||
| if (this.detectedFeatures?.length) return this.detectedFeatures; // memoized | ||
| this.log("debug", "detecting active features of Firebase MCP server..."); | ||
| this.logger.debug( "detecting active features of Firebase MCP server..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/mcp/index.ts
Outdated
| "debug", | ||
| "detected features of Firebase MCP server: " + (this.detectedFeatures.join(", ") || "<none>"), | ||
| this.logger.debug( | ||
| `detected features of Firebase MCP server: ${(this.detectedFeatures.join(", ") || "<none>")}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space after the colon in the log message. Removing it will improve formatting consistency.
| `detected features of Firebase MCP server: ${(this.detectedFeatures.join(", ") || "<none>")}`, | |
| `detected features of Firebase MCP server: ${(this.detectedFeatures.join(", ") || "<none>")}`, |
9d62b7c to
27bca0e
Compare
2c534bb to
9d87ce2
Compare
No description provided.