Add support for selecting devices when running automated tests #9387
Conversation
Summary of ChangesHello @tagboola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a foundational utility to programmatically fetch a list of available devices for app testing. This enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new tool, get_devices, for retrieving available devices for testing. This tool is added to the apptestingTools array. The get_devices tool uses the Google Cloud Testing API to fetch device information based on the specified device type (e.g., ANDROID).
| async ({ type }) => { | ||
| const testing = google.testing("v1"); | ||
| return toContent( | ||
| await testing.testEnvironmentCatalog.get({ | ||
| oauth_token: await getAccessToken(), | ||
| environmentType: type, | ||
| }), | ||
| ); |
There was a problem hiding this comment.
The oauth_token parameter is deprecated. Consider using the auth parameter instead, which automatically handles authentication using the service account or user credentials. This simplifies the code and avoids potential issues with token management.
// Example using auth parameter
await testing.testEnvironmentCatalog.get({
auth: await google.auth.getClient({ scopes: ['https://www.googleapis.com/auth/cloud-platform'] }),
environmentType: type,
}); const testing = google.testing("v1");
return toContent(
await testing.testEnvironmentCatalog.get({
auth: await google.auth.getClient({ scopes: ['https://www.googleapis.com/auth/cloud-platform'] }),
environmentType: type,
}),
);There was a problem hiding this comment.
Hmm, oauth_token does not seem to be deprecated 🤔
| }), | ||
| }, | ||
| async ({ type }) => { | ||
| const testing = google.testing("v1"); |
There was a problem hiding this comment.
Maybe call this testingClient or gtestClient?
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
tagboola
changed the title
2 participants
Description
Add a tool for getting available devices for testing and update prompt to use the tool.
Scenarios Tested
Sample Commands