-
Couldn't load subscription status.
- Fork 1.1k
BREAKING: hide functions:config:* commands by default #9340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
We'll gate all mutating functions:config:* commands behind the new legacyRuntimeConfigCommands experiment. We'll keep functions:config:{get,export} available for inspection.
Some minor refactoring to align deprecation message across all surfaces.
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new experiment flag, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a breaking change by hiding the functions:config:* commands behind the legacyRuntimeConfigCommands experiment, while keeping functions:config:{get,export} available. It also refactors the deprecation message for consistency. The review focuses on the correctness of the changes, particularly around the experiment flag and the deprecation warnings.
…-tools into dl-hide-fn-cfg
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
We'll gate all mutating functions:config:* commands behind the new
legacyRuntimeConfigCommandsexperiment. We'll keep functions:config:{get,export} available for inspection.Includes some minor refactoring to align deprecation message across all surfaces.