Improve secret parameter support for firebase functions.

[taeold]

Key changes:

• Added --format flag to functions:secrets:set command
• Auto-detect JSON format from .json file extensions
• Added format field to SecretParam interface for deploy-time handling
• Use visible input() prompt for JSON secrets vs password() for regular secrets
• Validate JSON format before storing in Secret Manager
• Improved error messages with actionable commands for developers
• Added non-interactive mode check with helpful error for missing secrets

Example usage:
$ firebase functions:secrets:set STRIPE_CONFIG --format=json --data-file config.json
$ cat config.json | firebase functions:secrets:set STRIPE_CONFIG --format=json

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the secret management capabilities for Firebase Functions by introducing robust support for JSON-formatted secrets. It streamlines the process of setting and validating complex secret values, improves the interactive and non-interactive user experience with clearer prompts and error messages, and ensures data integrity by validating JSON inputs before storage. These changes make it easier for developers to manage structured configuration data as secrets.

Highlights

• JSON Secret Support: Introduced the ability to set secrets in JSON format, either explicitly via a new --format=json flag or implicitly by detecting .json file extensions when using --data-file.
• Improved User Experience: Enhanced the interactive prompt for setting secrets, using a visible input() for JSON values and password() for regular strings. Also, improved error messages now provide actionable commands for developers, especially when dealing with invalid JSON or missing secrets in non-interactive mode.
• Validation and Type Safety: Added client-side validation to ensure that values provided for JSON secrets are indeed valid JSON before being stored in Secret Manager. The SecretParam interface was updated to include a format field for better type handling during deployment.
• Non-Interactive Mode Handling: Implemented a check for missing secrets in non-interactive mode, which now throws a FirebaseError with clear instructions and example commands to set the required secrets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for JSON-formatted secrets in Firebase Functions, including a new --format flag for the functions:secrets:set command, auto-detection of JSON from file extensions, and appropriate handling during deployment. The changes are well-implemented, with improved error messages and prompts for a better developer experience. My feedback includes a critical fix for interactive JSON secret input to ensure it's visible, and a few minor suggestions to improve the clarity of error messages.

[taeold]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces valuable support for JSON-formatted secrets in Firebase Functions, including auto-detection from file extensions and improved error messaging. The implementation is well-structured. My feedback focuses on a couple of areas to enhance usability and maintainability: using a visible prompt for entering JSON secrets interactively and refactoring duplicated code for JSON validation.