-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding changelogs for community PRs #8851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the project's CHANGELOG.md file. It adds two new entries to document recent bug fixes that originated from community contributions, specifically addressing issues within the Cloud Task emulator and firestore:indexes functionality.
Highlights
- Documentation Update: Updated the
CHANGELOG.mdfile to include a fix for an issue where the Cloud Task emulator failed to decode non-ASCII characters (related to PR #8836). - Documentation Update: Updated the
CHANGELOG.mdfile to include a fix for an issue wherefirestore:indexesincorrectly removed the__name__field (related to PR #7629).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two entries to the changelog for recent community contributions. My review includes a suggestion to rephrase these new entries to improve consistency and conciseness with the existing format of the file.
| - Fixed an issue where the Cloud Task emulator couldn't decode non-ASCII characters. (#8836) | ||
| - Fixed an issue where `firestore:indexes` wrongly removed the `__name__` field. (#7629) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve consistency and conciseness in the changelog, I suggest rephrasing these entries to use the imperative mood, similar to the existing entries. This also resolves the inconsistent use of trailing periods.
Here's a suggestion for a more direct and scannable format:
| - Fixed an issue where the Cloud Task emulator couldn't decode non-ASCII characters. (#8836) | |
| - Fixed an issue where `firestore:indexes` wrongly removed the `__name__` field. (#7629) | |
| - Fix non-ASCII character decoding in the Cloud Task emulator (#8836) | |
| - Fix `firestore:indexes` incorrectly removing the `__name__` field (#7629) |
Description
Adding some change log entries for community PRs.