-
Notifications
You must be signed in to change notification settings - Fork 1k
implement mcp logging #8834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
implement mcp logging #8834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @antholeole, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Model Context Protocol (MCP) server by integrating comprehensive logging capabilities. It allows the server to emit structured log messages at various levels and provides a mechanism for clients to control the server's logging verbosity, improving observability and debugging within the MCP ecosystem.
Highlights
- New Logging Capabilities: Introduced
LoggingLevel
andSetLevelRequestSchema
types from the MCP SDK to support structured logging. - Log Level Management: Defined an
orderedLogLevels
constant and added acurrentLogLevel
property to theFirebaseMcpServer
to manage the server's logging verbosity. - Logger API: Implemented a
logger
property on theFirebaseMcpServer
class, providing a convenient API (e.g.,server.logger.info('message')
) for sending log messages at various levels. - MCP Server Integration: Registered 'logging' as a capability with the MCP server and added a request handler for
SetLevelRequestSchema
to allow clients to dynamically adjust the server's logging level. - Structured Logging Implementation: Added a private
log
method that formats string messages into JSON objects (as required by the MCP protocol) and applies log level filtering before sending messages viathis.server.sendLoggingMessage
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds MCP logging capabilities to the server, including a logger interface, handling for setting the log level, and sending log messages to the client. The implementation is generally well-structured, but I found a critical issue in the log level filtering logic which causes it to filter messages incorrectly. I've provided a suggestion to fix this.
da6c911
to
9725bbc
Compare
Description
Add MCP logging to the MCP server