[feat] initial impl of apptesting #8799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
reviewed
Jun 27, 2025
Contributor
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
This looks great! Some minor comments but overall LGTM
| apiOrigin: appTestingOrigin(), | ||
| apiVersion: "v1alpha", | ||
| operationResourceName: operationName, | ||
| masterTimeout: 30 * 60 * 1000, // 30 minutes |
Contributor
There was a problem hiding this comment.
30 minutes is quite a long time - what is the usual amount of time these run for?
If it is particularly long (ie 5+ minutes), we probably should call that out in the logs in apphosting-execute.ts
Contributor
Author
There was a problem hiding this comment.
5-10 minutes would probably be 'normal', but since this could be a large number of complex integration tests, it's possible it could be longer. I have a generic "this can take a while" message in the execute command, is there something more specific you would want to see there?
Contributor
|
Oh, also add an entry to CHANGELOG.md! |
kaibolay
reviewed
Jun 30, 2025
kaibolay
approved these changes
Jul 7, 2025
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
…o TestCaseInvocation
joehan
approved these changes
Jul 8, 2025
joehan
reviewed
Jul 8, 2025
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation of firebase apptesting commands.
Scenarios Tested
We've tested firebase apptesting:init and firebase apptesting:execute through a team bug bash.
Sample Commands
firebase apptesting:init - initializes the project for apptesting
firebase apptesting:execute - executes a suite of tests against a URL