feat: Implement --ephemeral flag to prevent emulator data export #8787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --ephemeral flag for the `emulators:start` command ensures that no
data is exported when the emulators stop, even if `--export-on-exit`
is specified or if the `emulators:export` command is used during the session.
Import functionality remains unaffected when using `--ephemeral` with `--import`.
Changes include:
- Modified `controller.ts` to check for `options.ephemeral` in
`exportOnExit` and `exportEmulatorData` functions, preventing export
and logging a message.
- Added integration tests in `scripts/emulator-import-export-tests/tests.ts`
to verify:
- No export occurs with `--export-on-exit` in ephemeral mode.
- Data import works, but subsequent export is prevented in ephemeral mode.
- The `emulators:export` command does not export data if emulators
were started with `--ephemeral`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --ephemeral flag for the
emulators:startcommand ensures that no data is exported when the emulators stop, even if--export-on-exitis specified or if theemulators:exportcommand is used during the session.Import functionality remains unaffected when using
--ephemeralwith--import.Changes include:
controller.tsto check foroptions.ephemeralinexportOnExitandexportEmulatorDatafunctions, preventing export and logging a message.scripts/emulator-import-export-tests/tests.tsto verify:--export-on-exitin ephemeral mode.emulators:exportcommand does not export data if emulators were started with--ephemeral.