[MCP] Add a list_dataconnect_services MCP tool #8485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
changed the title
fredzqm
changed the title
fredzqm
commented
Apr 30, 2025
| async (_, { projectId }) => { | ||
| if (!projectId) return mcpError("No current project detected."); | ||
| const services = await client.listAllServices(projectId); | ||
| return toContent(services, { format: "yaml" }); |
Contributor
Author
There was a problem hiding this comment.
For the error handling.
Honestly, I think it should be the caller's responsibility to check for unchecked exception.
WIll send a follow-up PR to cleanup.
Contributor
There was a problem hiding this comment.
I think you're probably right. I'll do a PR to do some universal error handling in the tool setup.
mbleigh
approved these changes
Apr 30, 2025
| async (_, { projectId }) => { | ||
| if (!projectId) return mcpError("No current project detected."); | ||
| const services = await client.listAllServices(projectId); | ||
| return toContent(services, { format: "yaml" }); |
Contributor
There was a problem hiding this comment.
I think you're probably right. I'll do a PR to do some universal error handling in the tool setup.
Co-authored-by: Michael Bleigh <bleigh@google.com>
blidd-google
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the first FDC tool.
list_dataconnect_servicestalks to the backend API and returns the list of services available.Scenarios Tested
Sample Commands