fix: prevent failure when deleting cloud function with missing schedule

src/deploy/functions/release/fabricator.ts

@@ -123,7 +123,7 @@
       try {
         await fn();
         this.logOpSuccess(op, endpoint);
       } catch (err: any) {
         result.error = err as Error;
       }
       result.durationMs = timer.stop();
@@ -214,7 +214,38 @@
   }
 
   async deleteEndpoint(endpoint: backend.Endpoint): Promise<void> {
-    await this.deleteTrigger(endpoint);
+    try{
+      await this.deleteTrigger(endpoint);
+    }
+    catch(err) {
+      /**
+       * In cases where a function has been partially deleted, 
+       * we may encounter errors on subsequent attempts to delete it.
+       * 
+       * For example, if an account lacking the `pubsub.topics.delete` permission
+       * attempts to delete a function with a Pub/Sub trigger, the trigger will be
+       * deleted but the topic will not. This will cause the function deletion
+       * to fail on subsequent attempts.
+       * 
+       */
+      if (
+          err instanceof reporter.DeploymentError && 
+          err.op == "delete schedule" && 
+          (err.original as FirebaseError).message == "HTTP Error: 404, Job not found."
+        ) {
+          logger.warn(`Cloud Scheduler job for ${endpoint.id} not found. It may have been deleted out of band. Continuing to delete function.`);
+      }
+      else if (
+          err instanceof reporter.DeploymentError && 
+          err.op == "delete topic" && 
+          err.message.startsWith("Failed to delete topic function")
+        ) {
+          logger.warn(`Failed to delete topic function for ${endpoint.id}. Ensure the account has 'pubsub.topics.delete' permission.  You may need to manually delete the topic.  Continuing to delete function.`);
+      }
+      else {
+        throw err;
+      }
+    }
     if (endpoint.platform === "gcfv1") {
       await this.deleteV1Function(endpoint);
     } else {
@@ -223,7 +254,7 @@
   }
 
   async createV1Function(endpoint: backend.Endpoint, scraper: SourceTokenScraper): Promise<void> {
     const sourceUrl = this.sources[endpoint.codebase!]?.sourceUrl;
     if (!sourceUrl) {
       logger.debug("Precondition failed. Cannot create a GCF function without sourceUrl");
       throw new Error("Precondition failed");
@@ -242,7 +273,7 @@
         const op: { name: string } = await gcf.createFunction(apiFunction);
         return poller.pollOperation<gcf.CloudFunction>({
           ...gcfV1PollerOptions,
           pollerName: `create-${endpoint.codebase}-${endpoint.region}-${endpoint.id}`,
           operationResourceName: op.name,
           onPoll: scraper.poller,
         });
@@ -279,7 +310,7 @@
       }
     } else if (
       backend.isBlockingTriggered(endpoint) &&
       AUTH_BLOCKING_EVENTS.includes(endpoint.blockingTrigger.eventType as any)
     ) {
       // Auth Blocking functions should always be public
       await this.executor
@@ -291,7 +322,7 @@
   }
 
   async createV2Function(endpoint: backend.Endpoint, scraper: SourceTokenScraper): Promise<void> {
     const storageSource = this.sources[endpoint.codebase!]?.storage;
     if (!storageSource) {
       logger.debug("Precondition failed. Cannot create a GCFv2 function without storage");
       throw new Error("Precondition failed");
@@ -307,15 +338,15 @@
         .run(async () => {
           try {
             await pubsub.createTopic({ name: topic });
           } catch (err: any) {
             // Pub/Sub uses HTTP 409 (CONFLICT) with a status message of
             // ALREADY_EXISTS if the topic already exists.
             if (err.status === 409) {
               return;
             }
             throw new FirebaseError("Unexpected error creating Pub/Sub topic", {
               original: err as Error,
               status: err.status,
             });
           }
         })

src/gcp/cloudscheduler.ts

@@ -147,7 +147,11 @@ export async function createOrReplaceJob(job: Job): Promise<any> {
   const jobName = job.name.split("/").pop();
   const existingJob = await getJob(job.name);
   // if no job is found, create one
-  if (existingJob.status === 404) {
+  if (existingJob.status === 403) {
+    throw new FirebaseError(`Failed to create scheduler job ${job.name}: Ensure you have the 'cloudscheduler.jobs.get' permission`);
+
+  }
+  else if (existingJob.status === 404) {
     let newJob;
     try {
       newJob = await createJob(job);