Report errors in configs, and load configs from anywhere #7650
Conversation
This avoids the extension overwriting the selected project if the RC file is manually edited.
rrousselGit
force-pushed
the
validate-configs-open-folder
branch
from
6c85a19
to
5734e4f
Compare
rrousselGit
changed the title
| error: err, | ||
| range: new vscode.Range(0, 0, 0, 0), | ||
| }; | ||
| }, | ||
| ); | ||
|
|
||
| cancel = |
There was a problem hiding this comment.
not following the purpose of the cancel. Is this on shutdown?
There was a problem hiding this comment.
Shutdown or when the function runs again.
We don't want to keep adding new listeners again and again.
There was a problem hiding this comment.
Switch to using effect cleanup like in another part of the code
| return this.switchCase<Promise<Result<NewT>>>( | ||
| (value) => cb(value), | ||
| async (error) => new ResultError(error) | ||
| followAsync<NewT, ErrorT>( |
There was a problem hiding this comment.
Can you leave some comments explaining the purpose of follow and followAsync?
I may be unfamiliar with "follow" terminology, but it seems more like a callback executor w/ error resolver?
There was a problem hiding this comment.
Added some docs
There was a problem hiding this comment.
Please clean up console.logs.
Please assign effects/subscriptions to named variables (serving as descriptors), and push them to context.subscriptions altogether.
Please name disposables as e.g. "watcherDisposable" when appropriate.
Thanks!
|
I think I've addressed everything :) |
Description
Scenarios Tested
Sample Commands