Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Hosting: add github branch validation #7371

Merged
merged 12 commits into from
Jul 8, 2024

Conversation

mathu97
Copy link
Contributor

@mathu97 mathu97 commented Jun 24, 2024

Ensures that the branch entered by user is a valid branch that is available in their repo.

@mathu97 mathu97 marked this pull request as ready for review June 28, 2024 18:07
@mathu97 mathu97 changed the title add github branch verification App Hosting: add github branch validation Jun 28, 2024
@mathu97 mathu97 requested a review from tonyjhuang June 28, 2024 18:45
Copy link
Contributor

@tonyjhuang tonyjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments feel free to merge after addressing

src/apphosting/githubConnections.ts Outdated Show resolved Hide resolved
src/apphosting/githubConnections.ts Outdated Show resolved Hide resolved
src/gcp/devConnect.ts Outdated Show resolved Hide resolved
@mathu97 mathu97 enabled auto-merge (squash) July 8, 2024 17:36
@mathu97 mathu97 merged commit 68ee635 into master Jul 8, 2024
40 of 41 checks passed
@mathu97 mathu97 deleted the mathusan/github-branch-verification branch July 8, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants